feat: add streaming download functionality for large files in AsyncFiles class#109
Merged
adubovik merged 7 commits intoJun 25, 2026
Merged
Conversation
…aming-downloads Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # aidial_client/resources/files.py
…notations in tests
adubovik
requested changes
Jun 22, 2026
…oad request preparation - Replaced inline error handling with a dedicated `_raise_for_status` method in both synchronous and asynchronous HTTP clients. - Introduced `_prepare_download_request` method in `DialStorageResourceMixin` to encapsulate download request logic, improving code clarity and reusability. - Updated type hints for `on_http_error` to use a consistent `ErrorHandler` type across the codebase.
- Simplified the error handling process by consolidating the raised error logic into a single line, enhancing readability and maintainability.
adubovik
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable issues
Fixes #91
Description of changes
AsyncHTTPClientvia a newstream(...)context manager that usesstream=Trueand closes responses safely.AsyncFiles.stream_download(...)to stream file downloads incrementally (without full buffering) while preserving existing error handling.stream_download()usage on large async downloads.stream=Truerequest behavior, response cleanup, and directory URL validation.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.